-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32-C3: Add support for booting from MCUboot bootloader #49
Conversation
7e38828
to
a24f132
Compare
a24f132
to
baba78e
Compare
74b5338
to
f2cea80
Compare
f2cea80
to
e89ee26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small comments, otherwise as far as the code is concerned this looks fine to me. @bjoernQ would you mind taking a quick look as well please whenever you get a chance (if you haven't already)?
If you wouldn't mind it would also be nice for there to be a small section in the README
briefly describing how to build and use this format. This isn't required, so if you're not feeling like doing it that's fine too, but would be appreciated!
Tested with the fixes to the linker script and everything is working as expected on my end, so once the review points have been addressed this should be good to merge! |
Signed-off-by: Gustavo Henrique Nihei <[email protected]>
e89ee26
to
38cd03d
Compare
Done! Created a new section on the |
Previously it assumed that the entry point was allocated at the beginning of the ".rwtext" output section, which is not always true. Signed-off-by: Gustavo Henrique Nihei <[email protected]>
Signed-off-by: Gustavo Henrique Nihei <[email protected]>
bfee5ee
to
b68319e
Compare
Signed-off-by: Gustavo Henrique Nihei <[email protected]>
b68319e
to
1ced513
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README looks great, thanks! I think we're good to go here, so thank you again for your patience and your continued work on this feature, I look forward to expanding on it in the future!
Summary
This PR intends to enable an esp-hal-based Rust application to be booted from the MCUboot bootloader on ESP32-C3.
MCUboot is a secure bootloader solution feature-wise equivalent to the IDF 2nd stage bootloader (current default bootloader).
You may find more information on the documentation pages for MCUboot and the Espressif port:
https://docs.mcuboot.com/
https://docs.mcuboot.com/readme-espressif.html
Testing
Hello World
example successfully executed from MCUboot bootloader onESP32-C3-DevKitM-1
board according to instructions from the updatedREADME.md
file.